fix: remove trailing newlines from migrations to prevent SQLITE_MISUSE errors

Python's sqlite3.executescript() has a bug where trailing newlines after
the final semicolon create empty statements. When APSW's log_sqlite() is
enabled (via apswutils, imported by fastmigrate), these cause visible
"API called with NULL prepared statement" errors during interpreter shutdown.

- Strip trailing newlines from all 9 existing migration files
- Update migration template to end with semicolon, no trailing newline
- Document the requirement in CLAUDE.md

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

CLAUDE.md

@@ -80,6 +80,11 @@ When handling animal selections:
 - Store feed amounts in grams (INTEGER) for precision
 - Display as kg with 3 decimals
 
+### Migrations
+- Migration files must end with `;` and NO trailing newline
+- Python's sqlite3.executescript() has a bug: trailing newlines after the final `;` create empty statements that cause SQLITE_MISUSE errors when APSW logging is enabled
+- Use `animaltrack create-migration "description"` to create new migrations (template handles this correctly)
+
 ## Refreshing Docs
 ```bash
 # FastHTML

migrations/0001-reference-tables.sql

@@ -49,4 +49,4 @@ CREATE TABLE users (
     active INTEGER NOT NULL DEFAULT 1 CHECK(active IN (0, 1)),
     created_at_utc INTEGER NOT NULL,
     updated_at_utc INTEGER NOT NULL
-);
+);

migrations/0002-event-tables.sql

@@ -53,4 +53,4 @@ CREATE TABLE event_animals (
     ts_utc INTEGER NOT NULL,
     PRIMARY KEY (event_id, animal_id)
 );
-CREATE UNIQUE INDEX ux_event_animals_animal_ts ON event_animals(animal_id, ts_utc);
+CREATE UNIQUE INDEX ux_event_animals_animal_ts ON event_animals(animal_id, ts_utc);

migrations/0003-animal-registry-schema.sql

@@ -55,4 +55,4 @@ CREATE TABLE animal_aliases (
     merged_at_utc INTEGER NOT NULL
 );
 
-CREATE INDEX idx_aa_survivor ON animal_aliases(survivor_animal_id);
+CREATE INDEX idx_aa_survivor ON animal_aliases(survivor_animal_id);

migrations/0004-interval-projections.sql

@@ -53,4 +53,4 @@ CREATE TABLE animal_attr_intervals (
 -- Index for "which animals had attr=value at time T" queries
 CREATE INDEX idx_aai_attr_time ON animal_attr_intervals(
     attr, value, start_utc, COALESCE(end_utc, 32503680000000)
-);
+);

migrations/0005-tag-suggestions.sql

@@ -12,4 +12,4 @@ CREATE TABLE tag_suggestions (
 );
 
 -- Index for sorting by popularity
-CREATE INDEX idx_tag_suggestions_popularity ON tag_suggestions(active_animals DESC, total_assignments DESC);
+CREATE INDEX idx_tag_suggestions_popularity ON tag_suggestions(active_animals DESC, total_assignments DESC);

migrations/0006-feed-inventory.sql

@@ -15,4 +15,4 @@ CREATE TABLE feed_inventory (
 );
 
 -- Index for finding when last purchase/given occurred
-CREATE INDEX idx_feed_inventory_last_on ON feed_inventory(last_purchase_at_utc, last_given_at_utc);
+CREATE INDEX idx_feed_inventory_last_on ON feed_inventory(last_purchase_at_utc, last_given_at_utc);

migrations/0007-egg-stats-30d.sql

@@ -19,4 +19,4 @@ CREATE TABLE egg_stats_30d_by_location (
 );
 
 -- Index for finding stale stats that need recomputation
-CREATE INDEX idx_egg_stats_updated ON egg_stats_30d_by_location(updated_at_utc);
+CREATE INDEX idx_egg_stats_updated ON egg_stats_30d_by_location(updated_at_utc);

migrations/0008-event-log-by-location.sql

@@ -24,4 +24,4 @@ BEGIN
         ORDER BY ts_utc DESC
         LIMIT -1 OFFSET 500
     );
-END;
+END;

migrations/0009-user-defaults.sql

@@ -14,4 +14,4 @@ CREATE TABLE user_defaults (
   PRIMARY KEY (username, action)
 );
 
-CREATE INDEX idx_user_defaults_username ON user_defaults(username);
+CREATE INDEX idx_user_defaults_username ON user_defaults(username);

src/animaltrack/migrations.py

@@ -94,12 +94,13 @@ def create_migration(migrations_dir: str | Path, description: str) -> Path:
     filepath = migrations_path / filename
 
     # SQL template with ABOUTME header
+    # NOTE: Template must NOT end with trailing newline after final semicolon.
+    # Python's sqlite3.executescript() has a bug where trailing newlines create
+    # empty statements that cause SQLITE_MISUSE errors when APSW logging is enabled.
     template = f"""-- ABOUTME: Migration {index:04d} - {description}
 -- ABOUTME: Created for AnimalTrack database schema versioning.
 
--- Write your migration SQL here
+-- Write your migration SQL here;"""
-
-"""
 
     filepath.write_text(template)
     return filepath