feat: add repositories and reference data seeder

Implements Step 1.5: Creates ULID generation utility, repositories for
all reference types (species, locations, products, feed_types, users),
and an idempotent seeder that populates initial data. Updates CLI seed
command to run migrations and seed data.

Seed data:
- 3 users (ppetru, ines as admin; guest as recorder)
- 8 locations (Strip 1-4, Nursery 1-4)
- 3 species (duck, goose active; sheep inactive)
- 7 products (egg.duck, meat, offal, fat, bones, feathers, down)
- 3 feed types (starter, grower, layer - 20kg bags)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
2025-12-27 19:40:55 +00:00
parent 34b2421604
commit 4579229734
12 changed files with 1456 additions and 2 deletions

30
tests/test_id_gen.py Normal file
View File

@@ -0,0 +1,30 @@
# ABOUTME: Tests for ULID generation utility.
# ABOUTME: Verifies that generated IDs are valid 26-character ULIDs and unique.
from animaltrack.id_gen import generate_id
class TestGenerateId:
"""Tests for the generate_id function."""
def test_returns_string(self):
"""generate_id returns a string."""
result = generate_id()
assert isinstance(result, str)
def test_returns_26_characters(self):
"""generate_id returns exactly 26 characters (ULID format)."""
result = generate_id()
assert len(result) == 26
def test_returns_unique_ids(self):
"""generate_id returns unique IDs on each call."""
ids = [generate_id() for _ in range(100)]
assert len(set(ids)) == 100
def test_ulid_is_uppercase_alphanumeric(self):
"""ULID contains only uppercase letters and digits (Crockford base32)."""
result = generate_id()
# Crockford base32 excludes I, L, O, U
valid_chars = set("0123456789ABCDEFGHJKMNPQRSTVWXYZ")
assert all(c in valid_chars for c in result)

422
tests/test_repositories.py Normal file
View File

@@ -0,0 +1,422 @@
# ABOUTME: Tests for reference data repositories.
# ABOUTME: Validates CRUD operations for species, locations, products, feed_types, and users.
import time
import pytest
from animaltrack.db import get_db
from animaltrack.id_gen import generate_id
from animaltrack.migrations import run_migrations
from animaltrack.models.reference import (
FeedType,
Location,
Product,
ProductUnit,
Species,
User,
UserRole,
)
from animaltrack.repositories import (
FeedTypeRepository,
LocationRepository,
ProductRepository,
SpeciesRepository,
UserRepository,
)
@pytest.fixture
def migrated_db(tmp_path):
"""Create a database with migrations applied."""
db_path = str(tmp_path / "test.db")
run_migrations(db_path, "migrations", verbose=False)
return get_db(db_path)
@pytest.fixture
def now_utc():
"""Current time in milliseconds since epoch."""
return int(time.time() * 1000)
class TestSpeciesRepository:
"""Tests for SpeciesRepository."""
def test_upsert_creates_new_record(self, migrated_db, now_utc):
"""upsert creates a new species record."""
repo = SpeciesRepository(migrated_db)
species = Species(
code="duck",
name="Duck",
active=True,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
repo.upsert(species)
result = repo.get("duck")
assert result is not None
assert result.code == "duck"
assert result.name == "Duck"
assert result.active is True
def test_upsert_updates_existing_record(self, migrated_db, now_utc):
"""upsert updates an existing species record."""
repo = SpeciesRepository(migrated_db)
species = Species(
code="duck",
name="Duck",
active=True,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
repo.upsert(species)
updated = Species(
code="duck",
name="Domestic Duck",
active=False,
created_at_utc=now_utc,
updated_at_utc=now_utc + 1000,
)
repo.upsert(updated)
result = repo.get("duck")
assert result.name == "Domestic Duck"
assert result.active is False
def test_get_returns_none_for_missing(self, migrated_db):
"""get returns None for non-existent species."""
repo = SpeciesRepository(migrated_db)
assert repo.get("nonexistent") is None
def test_list_all_returns_all_records(self, migrated_db, now_utc):
"""list_all returns all species."""
repo = SpeciesRepository(migrated_db)
repo.upsert(
Species(
code="duck",
name="Duck",
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
)
repo.upsert(
Species(
code="goose",
name="Goose",
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
)
results = repo.list_all()
assert len(results) == 2
codes = {s.code for s in results}
assert codes == {"duck", "goose"}
class TestLocationRepository:
"""Tests for LocationRepository."""
def test_upsert_creates_new_record(self, migrated_db, now_utc):
"""upsert creates a new location record."""
repo = LocationRepository(migrated_db)
location_id = generate_id()
location = Location(
id=location_id,
name="Strip 1",
active=True,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
repo.upsert(location)
result = repo.get(location_id)
assert result is not None
assert result.name == "Strip 1"
def test_upsert_updates_existing_record(self, migrated_db, now_utc):
"""upsert updates an existing location record."""
repo = LocationRepository(migrated_db)
location_id = generate_id()
location = Location(
id=location_id,
name="Strip 1",
active=True,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
repo.upsert(location)
updated = Location(
id=location_id,
name="Strip 1 - Renamed",
active=False,
created_at_utc=now_utc,
updated_at_utc=now_utc + 1000,
)
repo.upsert(updated)
result = repo.get(location_id)
assert result.name == "Strip 1 - Renamed"
assert result.active is False
def test_get_by_name_returns_location(self, migrated_db, now_utc):
"""get_by_name returns location by name."""
repo = LocationRepository(migrated_db)
location_id = generate_id()
location = Location(
id=location_id,
name="Nursery 1",
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
repo.upsert(location)
result = repo.get_by_name("Nursery 1")
assert result is not None
assert result.id == location_id
def test_get_by_name_returns_none_for_missing(self, migrated_db):
"""get_by_name returns None for non-existent location."""
repo = LocationRepository(migrated_db)
assert repo.get_by_name("Nonexistent") is None
def test_list_all_returns_all_records(self, migrated_db, now_utc):
"""list_all returns all locations."""
repo = LocationRepository(migrated_db)
repo.upsert(
Location(
id=generate_id(),
name="Strip 1",
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
)
repo.upsert(
Location(
id=generate_id(),
name="Strip 2",
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
)
results = repo.list_all()
assert len(results) == 2
class TestProductRepository:
"""Tests for ProductRepository."""
def test_upsert_creates_new_record(self, migrated_db, now_utc):
"""upsert creates a new product record."""
repo = ProductRepository(migrated_db)
product = Product(
code="egg.duck",
name="Duck Egg",
unit=ProductUnit.PIECE,
collectable=True,
sellable=True,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
repo.upsert(product)
result = repo.get("egg.duck")
assert result is not None
assert result.name == "Duck Egg"
assert result.unit == ProductUnit.PIECE
def test_upsert_updates_existing_record(self, migrated_db, now_utc):
"""upsert updates an existing product record."""
repo = ProductRepository(migrated_db)
product = Product(
code="meat",
name="Meat",
unit=ProductUnit.KG,
collectable=True,
sellable=True,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
repo.upsert(product)
updated = Product(
code="meat",
name="Fresh Meat",
unit=ProductUnit.KG,
collectable=True,
sellable=False,
created_at_utc=now_utc,
updated_at_utc=now_utc + 1000,
)
repo.upsert(updated)
result = repo.get("meat")
assert result.name == "Fresh Meat"
assert result.sellable is False
def test_list_all_returns_all_records(self, migrated_db, now_utc):
"""list_all returns all products."""
repo = ProductRepository(migrated_db)
repo.upsert(
Product(
code="egg.duck",
name="Duck Egg",
unit=ProductUnit.PIECE,
collectable=True,
sellable=True,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
)
repo.upsert(
Product(
code="meat",
name="Meat",
unit=ProductUnit.KG,
collectable=True,
sellable=True,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
)
results = repo.list_all()
assert len(results) == 2
class TestFeedTypeRepository:
"""Tests for FeedTypeRepository."""
def test_upsert_creates_new_record(self, migrated_db, now_utc):
"""upsert creates a new feed type record."""
repo = FeedTypeRepository(migrated_db)
feed_type = FeedType(
code="layer",
name="Layer Feed",
default_bag_size_kg=20,
protein_pct=16.5,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
repo.upsert(feed_type)
result = repo.get("layer")
assert result is not None
assert result.name == "Layer Feed"
assert result.default_bag_size_kg == 20
assert result.protein_pct == 16.5
def test_upsert_with_null_protein(self, migrated_db, now_utc):
"""upsert handles None protein_pct correctly."""
repo = FeedTypeRepository(migrated_db)
feed_type = FeedType(
code="starter",
name="Starter Feed",
default_bag_size_kg=20,
protein_pct=None,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
repo.upsert(feed_type)
result = repo.get("starter")
assert result.protein_pct is None
def test_list_all_returns_all_records(self, migrated_db, now_utc):
"""list_all returns all feed types."""
repo = FeedTypeRepository(migrated_db)
repo.upsert(
FeedType(
code="starter",
name="Starter",
default_bag_size_kg=20,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
)
repo.upsert(
FeedType(
code="grower",
name="Grower",
default_bag_size_kg=25,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
)
results = repo.list_all()
assert len(results) == 2
class TestUserRepository:
"""Tests for UserRepository."""
def test_upsert_creates_new_record(self, migrated_db, now_utc):
"""upsert creates a new user record."""
repo = UserRepository(migrated_db)
user = User(
username="ppetru",
role=UserRole.ADMIN,
active=True,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
repo.upsert(user)
result = repo.get("ppetru")
assert result is not None
assert result.username == "ppetru"
assert result.role == UserRole.ADMIN
def test_upsert_updates_existing_record(self, migrated_db, now_utc):
"""upsert updates an existing user record."""
repo = UserRepository(migrated_db)
user = User(
username="guest",
role=UserRole.RECORDER,
active=True,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
repo.upsert(user)
updated = User(
username="guest",
role=UserRole.ADMIN,
active=False,
created_at_utc=now_utc,
updated_at_utc=now_utc + 1000,
)
repo.upsert(updated)
result = repo.get("guest")
assert result.role == UserRole.ADMIN
assert result.active is False
def test_list_all_returns_all_records(self, migrated_db, now_utc):
"""list_all returns all users."""
repo = UserRepository(migrated_db)
repo.upsert(
User(
username="ppetru",
role=UserRole.ADMIN,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
)
repo.upsert(
User(
username="guest",
role=UserRole.RECORDER,
created_at_utc=now_utc,
updated_at_utc=now_utc,
)
)
results = repo.list_all()
assert len(results) == 2

242
tests/test_seeds.py Normal file
View File

@@ -0,0 +1,242 @@
# ABOUTME: Tests for the reference data seeder.
# ABOUTME: Validates that seeding populates correct data and is idempotent.
import pytest
from animaltrack.db import get_db
from animaltrack.migrations import run_migrations
from animaltrack.models.reference import ProductUnit, UserRole
from animaltrack.repositories import (
FeedTypeRepository,
LocationRepository,
ProductRepository,
SpeciesRepository,
UserRepository,
)
from animaltrack.seeds import run_seeds
@pytest.fixture
def migrated_db(tmp_path):
"""Create a database with migrations applied."""
db_path = str(tmp_path / "test.db")
run_migrations(db_path, "migrations", verbose=False)
return get_db(db_path)
class TestSeedCounts:
"""Tests that seeding creates the correct number of records."""
def test_seeds_three_users(self, migrated_db):
"""Seeding creates 3 users."""
run_seeds(migrated_db)
repo = UserRepository(migrated_db)
assert len(repo.list_all()) == 3
def test_seeds_eight_locations(self, migrated_db):
"""Seeding creates 8 locations."""
run_seeds(migrated_db)
repo = LocationRepository(migrated_db)
assert len(repo.list_all()) == 8
def test_seeds_three_species(self, migrated_db):
"""Seeding creates 3 species."""
run_seeds(migrated_db)
repo = SpeciesRepository(migrated_db)
assert len(repo.list_all()) == 3
def test_seeds_seven_products(self, migrated_db):
"""Seeding creates 7 products."""
run_seeds(migrated_db)
repo = ProductRepository(migrated_db)
assert len(repo.list_all()) == 7
def test_seeds_three_feed_types(self, migrated_db):
"""Seeding creates 3 feed types."""
run_seeds(migrated_db)
repo = FeedTypeRepository(migrated_db)
assert len(repo.list_all()) == 3
class TestSeedIdempotency:
"""Tests that seeding is idempotent."""
def test_seeding_twice_same_user_count(self, migrated_db):
"""Seeding twice produces same number of users."""
run_seeds(migrated_db)
run_seeds(migrated_db)
repo = UserRepository(migrated_db)
assert len(repo.list_all()) == 3
def test_seeding_twice_same_location_count(self, migrated_db):
"""Seeding twice produces same number of locations."""
run_seeds(migrated_db)
run_seeds(migrated_db)
repo = LocationRepository(migrated_db)
assert len(repo.list_all()) == 8
def test_seeding_twice_same_species_count(self, migrated_db):
"""Seeding twice produces same number of species."""
run_seeds(migrated_db)
run_seeds(migrated_db)
repo = SpeciesRepository(migrated_db)
assert len(repo.list_all()) == 3
def test_seeding_twice_same_product_count(self, migrated_db):
"""Seeding twice produces same number of products."""
run_seeds(migrated_db)
run_seeds(migrated_db)
repo = ProductRepository(migrated_db)
assert len(repo.list_all()) == 7
def test_seeding_twice_same_feed_type_count(self, migrated_db):
"""Seeding twice produces same number of feed types."""
run_seeds(migrated_db)
run_seeds(migrated_db)
repo = FeedTypeRepository(migrated_db)
assert len(repo.list_all()) == 3
class TestUserSeedData:
"""Tests for correct user seed data."""
def test_ppetru_is_admin(self, migrated_db):
"""User ppetru has admin role."""
run_seeds(migrated_db)
repo = UserRepository(migrated_db)
user = repo.get("ppetru")
assert user is not None
assert user.role == UserRole.ADMIN
assert user.active is True
def test_ines_is_admin(self, migrated_db):
"""User ines has admin role."""
run_seeds(migrated_db)
repo = UserRepository(migrated_db)
user = repo.get("ines")
assert user is not None
assert user.role == UserRole.ADMIN
def test_guest_is_recorder(self, migrated_db):
"""User guest has recorder role."""
run_seeds(migrated_db)
repo = UserRepository(migrated_db)
user = repo.get("guest")
assert user is not None
assert user.role == UserRole.RECORDER
class TestLocationSeedData:
"""Tests for correct location seed data."""
def test_strip_locations_exist(self, migrated_db):
"""All 4 strip locations exist."""
run_seeds(migrated_db)
repo = LocationRepository(migrated_db)
for i in range(1, 5):
location = repo.get_by_name(f"Strip {i}")
assert location is not None, f"Strip {i} not found"
assert location.active is True
def test_nursery_locations_exist(self, migrated_db):
"""All 4 nursery locations exist."""
run_seeds(migrated_db)
repo = LocationRepository(migrated_db)
for i in range(1, 5):
location = repo.get_by_name(f"Nursery {i}")
assert location is not None, f"Nursery {i} not found"
assert location.active is True
def test_location_ids_are_valid_ulids(self, migrated_db):
"""All location IDs are 26 characters (ULID format)."""
run_seeds(migrated_db)
repo = LocationRepository(migrated_db)
for location in repo.list_all():
assert len(location.id) == 26
class TestSpeciesSeedData:
"""Tests for correct species seed data."""
def test_duck_is_active(self, migrated_db):
"""Species duck is active."""
run_seeds(migrated_db)
repo = SpeciesRepository(migrated_db)
species = repo.get("duck")
assert species is not None
assert species.name == "Duck"
assert species.active is True
def test_goose_is_active(self, migrated_db):
"""Species goose is active."""
run_seeds(migrated_db)
repo = SpeciesRepository(migrated_db)
species = repo.get("goose")
assert species is not None
assert species.name == "Goose"
assert species.active is True
def test_sheep_is_inactive(self, migrated_db):
"""Species sheep is inactive."""
run_seeds(migrated_db)
repo = SpeciesRepository(migrated_db)
species = repo.get("sheep")
assert species is not None
assert species.name == "Sheep"
assert species.active is False
class TestProductSeedData:
"""Tests for correct product seed data."""
def test_egg_duck_product(self, migrated_db):
"""Product egg.duck has correct attributes."""
run_seeds(migrated_db)
repo = ProductRepository(migrated_db)
product = repo.get("egg.duck")
assert product is not None
assert product.name == "Duck Egg"
assert product.unit == ProductUnit.PIECE
assert product.collectable is True
assert product.sellable is True
def test_meat_products_use_kg(self, migrated_db):
"""All meat-related products use kg unit."""
run_seeds(migrated_db)
repo = ProductRepository(migrated_db)
kg_products = ["meat", "offal", "fat", "bones", "feathers", "down"]
for code in kg_products:
product = repo.get(code)
assert product is not None, f"Product {code} not found"
assert product.unit == ProductUnit.KG, f"Product {code} should use kg"
class TestFeedTypeSeedData:
"""Tests for correct feed type seed data."""
def test_starter_feed_type(self, migrated_db):
"""Feed type starter has correct attributes."""
run_seeds(migrated_db)
repo = FeedTypeRepository(migrated_db)
feed_type = repo.get("starter")
assert feed_type is not None
assert feed_type.name == "Starter Feed"
assert feed_type.default_bag_size_kg == 20
def test_grower_feed_type(self, migrated_db):
"""Feed type grower has correct attributes."""
run_seeds(migrated_db)
repo = FeedTypeRepository(migrated_db)
feed_type = repo.get("grower")
assert feed_type is not None
assert feed_type.name == "Grower Feed"
assert feed_type.default_bag_size_kg == 20
def test_layer_feed_type(self, migrated_db):
"""Feed type layer has correct attributes."""
run_seeds(migrated_db)
repo = FeedTypeRepository(migrated_db)
feed_type = repo.get("layer")
assert feed_type is not None
assert feed_type.name == "Layer Feed"
assert feed_type.default_bag_size_kg == 20