Implement skeleton loading states for dashboard and routes (P3.8)
Add skeleton loading components per specs/dashboard.md requirements: - DecisionCardSkeleton: Shimmer placeholder for status and reason - DataPanelSkeleton: Skeleton rows for 5 metrics - NutritionPanelSkeleton: Skeleton for nutrition guidance - MiniCalendarSkeleton: Placeholder grid with navigation and legend - OverrideTogglesSkeleton: 4 toggle placeholders - CycleInfoSkeleton: Cycle day and phase placeholders - DashboardSkeleton: Combined skeleton for route-level loading Add Next.js loading.tsx files for instant loading states: - src/app/loading.tsx (Dashboard) - src/app/calendar/loading.tsx - src/app/history/loading.tsx - src/app/plan/loading.tsx - src/app/settings/loading.tsx Update dashboard page to use DashboardSkeleton instead of "Loading..." text. Fix flaky garmin test with wider date tolerance for timezone variations. 29 new tests in skeletons.test.tsx (749 total tests passing). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
275
src/components/dashboard/skeletons.test.tsx
Normal file
275
src/components/dashboard/skeletons.test.tsx
Normal file
@@ -0,0 +1,275 @@
|
||||
// ABOUTME: Tests for dashboard skeleton loading components.
|
||||
// ABOUTME: Verifies skeleton structure, accessibility, and shimmer animations.
|
||||
import { render, screen } from "@testing-library/react";
|
||||
import { describe, expect, it } from "vitest";
|
||||
import {
|
||||
CycleInfoSkeleton,
|
||||
DashboardSkeleton,
|
||||
DataPanelSkeleton,
|
||||
DecisionCardSkeleton,
|
||||
MiniCalendarSkeleton,
|
||||
NutritionPanelSkeleton,
|
||||
OverrideTogglesSkeleton,
|
||||
} from "./skeletons";
|
||||
|
||||
describe("DecisionCardSkeleton", () => {
|
||||
it("renders with loading aria label", () => {
|
||||
render(<DecisionCardSkeleton />);
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading decision/i }),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders shimmer placeholder for icon", () => {
|
||||
render(<DecisionCardSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading decision/i });
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-icon']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders shimmer placeholder for status", () => {
|
||||
render(<DecisionCardSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading decision/i });
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-status']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders shimmer placeholder for reason", () => {
|
||||
render(<DecisionCardSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading decision/i });
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-reason']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("has animate-pulse class for shimmer effect", () => {
|
||||
render(<DecisionCardSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading decision/i });
|
||||
expect(container).toHaveClass("animate-pulse");
|
||||
});
|
||||
});
|
||||
|
||||
describe("DataPanelSkeleton", () => {
|
||||
it("renders with loading aria label", () => {
|
||||
render(<DataPanelSkeleton />);
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading data/i }),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders header skeleton", () => {
|
||||
render(<DataPanelSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading data/i });
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-header']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders 5 skeleton rows for metrics", () => {
|
||||
render(<DataPanelSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading data/i });
|
||||
const rows = container.querySelectorAll("[data-testid='skeleton-row']");
|
||||
expect(rows).toHaveLength(5);
|
||||
});
|
||||
|
||||
it("has animate-pulse class for shimmer effect", () => {
|
||||
render(<DataPanelSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading data/i });
|
||||
expect(container).toHaveClass("animate-pulse");
|
||||
});
|
||||
});
|
||||
|
||||
describe("NutritionPanelSkeleton", () => {
|
||||
it("renders with loading aria label", () => {
|
||||
render(<NutritionPanelSkeleton />);
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading nutrition/i }),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders header skeleton", () => {
|
||||
render(<NutritionPanelSkeleton />);
|
||||
const container = screen.getByRole("region", {
|
||||
name: /loading nutrition/i,
|
||||
});
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-header']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders skeleton rows for nutrition guidance", () => {
|
||||
render(<NutritionPanelSkeleton />);
|
||||
const container = screen.getByRole("region", {
|
||||
name: /loading nutrition/i,
|
||||
});
|
||||
const rows = container.querySelectorAll("[data-testid='skeleton-row']");
|
||||
expect(rows.length).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
it("has animate-pulse class for shimmer effect", () => {
|
||||
render(<NutritionPanelSkeleton />);
|
||||
const container = screen.getByRole("region", {
|
||||
name: /loading nutrition/i,
|
||||
});
|
||||
expect(container).toHaveClass("animate-pulse");
|
||||
});
|
||||
});
|
||||
|
||||
describe("MiniCalendarSkeleton", () => {
|
||||
it("renders with loading aria label", () => {
|
||||
render(<MiniCalendarSkeleton />);
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading calendar/i }),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders header skeleton for cycle info", () => {
|
||||
render(<MiniCalendarSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading calendar/i });
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-cycle-info']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders navigation skeleton", () => {
|
||||
render(<MiniCalendarSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading calendar/i });
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-navigation']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders day header row with 7 cells", () => {
|
||||
render(<MiniCalendarSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading calendar/i });
|
||||
const dayHeaders = container.querySelectorAll(
|
||||
"[data-testid='skeleton-day-header']",
|
||||
);
|
||||
expect(dayHeaders).toHaveLength(7);
|
||||
});
|
||||
|
||||
it("renders placeholder grid for calendar days", () => {
|
||||
render(<MiniCalendarSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading calendar/i });
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-grid']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("has animate-pulse class for shimmer effect", () => {
|
||||
render(<MiniCalendarSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading calendar/i });
|
||||
expect(container).toHaveClass("animate-pulse");
|
||||
});
|
||||
|
||||
it("renders legend skeleton", () => {
|
||||
render(<MiniCalendarSkeleton />);
|
||||
const container = screen.getByRole("region", { name: /loading calendar/i });
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-legend']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
|
||||
describe("OverrideTogglesSkeleton", () => {
|
||||
it("renders with loading aria label", () => {
|
||||
render(<OverrideTogglesSkeleton />);
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading overrides/i }),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders header skeleton", () => {
|
||||
render(<OverrideTogglesSkeleton />);
|
||||
const container = screen.getByRole("region", {
|
||||
name: /loading overrides/i,
|
||||
});
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-header']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders 4 toggle skeletons", () => {
|
||||
render(<OverrideTogglesSkeleton />);
|
||||
const container = screen.getByRole("region", {
|
||||
name: /loading overrides/i,
|
||||
});
|
||||
const toggles = container.querySelectorAll(
|
||||
"[data-testid='skeleton-toggle']",
|
||||
);
|
||||
expect(toggles).toHaveLength(4);
|
||||
});
|
||||
|
||||
it("has animate-pulse class for shimmer effect", () => {
|
||||
render(<OverrideTogglesSkeleton />);
|
||||
const container = screen.getByRole("region", {
|
||||
name: /loading overrides/i,
|
||||
});
|
||||
expect(container).toHaveClass("animate-pulse");
|
||||
});
|
||||
});
|
||||
|
||||
describe("CycleInfoSkeleton", () => {
|
||||
it("renders with loading aria label", () => {
|
||||
render(<CycleInfoSkeleton />);
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading cycle info/i }),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders cycle day placeholder", () => {
|
||||
render(<CycleInfoSkeleton />);
|
||||
const container = screen.getByRole("region", {
|
||||
name: /loading cycle info/i,
|
||||
});
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-cycle-day']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("renders next phase placeholder", () => {
|
||||
render(<CycleInfoSkeleton />);
|
||||
const container = screen.getByRole("region", {
|
||||
name: /loading cycle info/i,
|
||||
});
|
||||
expect(
|
||||
container.querySelector("[data-testid='skeleton-next-phase']"),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("has animate-pulse class for shimmer effect", () => {
|
||||
render(<CycleInfoSkeleton />);
|
||||
const container = screen.getByRole("region", {
|
||||
name: /loading cycle info/i,
|
||||
});
|
||||
expect(container).toHaveClass("animate-pulse");
|
||||
});
|
||||
});
|
||||
|
||||
describe("DashboardSkeleton", () => {
|
||||
it("renders all skeleton components", () => {
|
||||
render(<DashboardSkeleton />);
|
||||
|
||||
// Should contain all skeleton regions
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading cycle info/i }),
|
||||
).toBeInTheDocument();
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading decision/i }),
|
||||
).toBeInTheDocument();
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading data/i }),
|
||||
).toBeInTheDocument();
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading nutrition/i }),
|
||||
).toBeInTheDocument();
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading overrides/i }),
|
||||
).toBeInTheDocument();
|
||||
expect(
|
||||
screen.getByRole("region", { name: /loading calendar/i }),
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
208
src/components/dashboard/skeletons.tsx
Normal file
208
src/components/dashboard/skeletons.tsx
Normal file
@@ -0,0 +1,208 @@
|
||||
// ABOUTME: Skeleton loading components for dashboard panels.
|
||||
// ABOUTME: Provides shimmer placeholders matching real component structure.
|
||||
|
||||
export function DecisionCardSkeleton() {
|
||||
return (
|
||||
<section
|
||||
aria-label="Loading decision"
|
||||
className="rounded-lg border p-6 animate-pulse"
|
||||
>
|
||||
{/* Icon placeholder */}
|
||||
<div
|
||||
data-testid="skeleton-icon"
|
||||
className="w-12 h-12 bg-gray-200 rounded-full mb-2"
|
||||
/>
|
||||
{/* Status placeholder */}
|
||||
<div
|
||||
data-testid="skeleton-status"
|
||||
className="h-8 w-32 bg-gray-200 rounded mb-2"
|
||||
/>
|
||||
{/* Reason placeholder */}
|
||||
<div
|
||||
data-testid="skeleton-reason"
|
||||
className="h-4 w-48 bg-gray-200 rounded"
|
||||
/>
|
||||
</section>
|
||||
);
|
||||
}
|
||||
|
||||
export function DataPanelSkeleton() {
|
||||
return (
|
||||
<section
|
||||
aria-label="Loading data"
|
||||
className="rounded-lg border p-4 animate-pulse"
|
||||
>
|
||||
{/* Header placeholder */}
|
||||
<div
|
||||
data-testid="skeleton-header"
|
||||
className="h-5 w-24 bg-gray-200 rounded mb-4"
|
||||
/>
|
||||
{/* 5 metric rows matching DataPanel structure */}
|
||||
<ul className="space-y-2">
|
||||
{[1, 2, 3, 4, 5].map((i) => (
|
||||
<li
|
||||
key={i}
|
||||
data-testid="skeleton-row"
|
||||
className="h-4 bg-gray-200 rounded w-3/4"
|
||||
/>
|
||||
))}
|
||||
</ul>
|
||||
</section>
|
||||
);
|
||||
}
|
||||
|
||||
export function NutritionPanelSkeleton() {
|
||||
return (
|
||||
<section
|
||||
aria-label="Loading nutrition"
|
||||
className="rounded-lg border p-4 animate-pulse"
|
||||
>
|
||||
{/* Header placeholder */}
|
||||
<div
|
||||
data-testid="skeleton-header"
|
||||
className="h-5 w-24 bg-gray-200 rounded mb-4"
|
||||
/>
|
||||
{/* 3 nutrition guidance rows */}
|
||||
<ul className="space-y-2">
|
||||
{[1, 2, 3].map((i) => (
|
||||
<li
|
||||
key={i}
|
||||
data-testid="skeleton-row"
|
||||
className="h-4 bg-gray-200 rounded w-3/4"
|
||||
/>
|
||||
))}
|
||||
</ul>
|
||||
</section>
|
||||
);
|
||||
}
|
||||
|
||||
export function MiniCalendarSkeleton() {
|
||||
return (
|
||||
<section
|
||||
aria-label="Loading calendar"
|
||||
className="rounded-lg border p-4 animate-pulse"
|
||||
>
|
||||
{/* Cycle info header placeholder */}
|
||||
<div
|
||||
data-testid="skeleton-cycle-info"
|
||||
className="h-5 w-32 bg-gray-200 rounded mb-2"
|
||||
/>
|
||||
|
||||
{/* Navigation placeholder */}
|
||||
<div
|
||||
data-testid="skeleton-navigation"
|
||||
className="flex items-center justify-between mb-3"
|
||||
>
|
||||
<div className="w-6 h-6 bg-gray-200 rounded" />
|
||||
<div className="flex items-center gap-2">
|
||||
<div className="h-4 w-28 bg-gray-200 rounded" />
|
||||
<div className="h-5 w-12 bg-gray-200 rounded" />
|
||||
</div>
|
||||
<div className="w-6 h-6 bg-gray-200 rounded" />
|
||||
</div>
|
||||
|
||||
{/* Day headers row */}
|
||||
<div className="grid grid-cols-7 gap-0.5 mb-1">
|
||||
{[1, 2, 3, 4, 5, 6, 7].map((i) => (
|
||||
<div
|
||||
key={i}
|
||||
data-testid="skeleton-day-header"
|
||||
className="h-4 w-4 mx-auto bg-gray-200 rounded"
|
||||
/>
|
||||
))}
|
||||
</div>
|
||||
|
||||
{/* Calendar grid placeholder - 5 rows of 7 days */}
|
||||
<div data-testid="skeleton-grid" className="grid grid-cols-7 gap-0.5">
|
||||
{Array.from({ length: 35 }).map((_, i) => (
|
||||
<div
|
||||
// biome-ignore lint/suspicious/noArrayIndexKey: Static skeleton placeholders never reorder
|
||||
key={`skeleton-day-${i}`}
|
||||
className="h-6 bg-gray-200 rounded"
|
||||
/>
|
||||
))}
|
||||
</div>
|
||||
|
||||
{/* Legend placeholder */}
|
||||
<div
|
||||
data-testid="skeleton-legend"
|
||||
className="mt-3 flex flex-wrap gap-2 justify-center"
|
||||
>
|
||||
{[1, 2, 3, 4, 5].map((i) => (
|
||||
<div key={i} className="flex items-center gap-0.5">
|
||||
<div className="w-2 h-2 bg-gray-200 rounded" />
|
||||
<div className="h-3 w-12 bg-gray-200 rounded" />
|
||||
</div>
|
||||
))}
|
||||
</div>
|
||||
</section>
|
||||
);
|
||||
}
|
||||
|
||||
export function OverrideTogglesSkeleton() {
|
||||
return (
|
||||
<section
|
||||
aria-label="Loading overrides"
|
||||
className="rounded-lg border p-4 animate-pulse"
|
||||
>
|
||||
{/* Header placeholder */}
|
||||
<div
|
||||
data-testid="skeleton-header"
|
||||
className="h-5 w-24 bg-gray-200 rounded mb-4"
|
||||
/>
|
||||
{/* 4 toggle rows matching OverrideToggles structure */}
|
||||
<ul className="space-y-2">
|
||||
{[1, 2, 3, 4].map((i) => (
|
||||
<li
|
||||
key={i}
|
||||
data-testid="skeleton-toggle"
|
||||
className="flex items-center gap-2"
|
||||
>
|
||||
<div className="w-4 h-4 bg-gray-200 rounded" />
|
||||
<div className="h-4 bg-gray-200 rounded w-24" />
|
||||
</li>
|
||||
))}
|
||||
</ul>
|
||||
</section>
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Skeleton for the cycle info header on the dashboard.
|
||||
*/
|
||||
export function CycleInfoSkeleton() {
|
||||
return (
|
||||
<section
|
||||
aria-label="Loading cycle info"
|
||||
className="text-center animate-pulse"
|
||||
>
|
||||
<div
|
||||
data-testid="skeleton-cycle-day"
|
||||
className="h-6 w-40 bg-gray-200 rounded mx-auto mb-2"
|
||||
/>
|
||||
<div
|
||||
data-testid="skeleton-next-phase"
|
||||
className="h-4 w-48 bg-gray-200 rounded mx-auto"
|
||||
/>
|
||||
</section>
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Combined skeleton for the entire dashboard loading state.
|
||||
* Use this in loading.tsx for route-level loading.
|
||||
*/
|
||||
export function DashboardSkeleton() {
|
||||
return (
|
||||
<div className="space-y-6">
|
||||
<CycleInfoSkeleton />
|
||||
<DecisionCardSkeleton />
|
||||
<div className="grid gap-4 md:grid-cols-2">
|
||||
<DataPanelSkeleton />
|
||||
<NutritionPanelSkeleton />
|
||||
</div>
|
||||
<OverrideTogglesSkeleton />
|
||||
<MiniCalendarSkeleton />
|
||||
</div>
|
||||
);
|
||||
}
|
||||
Reference in New Issue
Block a user