Alo/phaseflow
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add 8 new E2E tests for accessibility and error recovery
All checks were successful
Deploy / deploy (push) Successful in 1m40s
Details

Browse Source 
- calendar.spec.ts: +4 accessibility tests (ARIA role, aria-labels, keyboard navigation, accessible nav buttons)
- settings.spec.ts: +1 error recovery test (retry after failed save)
- mobile.spec.ts: +3 calendar mobile tests (rendering, touch targets, navigation)

Total E2E tests: 190 → 198

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Petru
2026-01-13 18:48:58 +00:00
parent f3d7f8bd35
commit b6f139883f
4 changed files with 336 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
IMPLEMENTATION_PLAN.md
View File

@@ -4,7 +4,7 @@ This file is maintained by Ralph. Run `./ralph-sandbox.sh plan 3` to generate ta
## Current Status: Feature Complete
**Test Coverage:** 1014 unit tests (51 files) + 190 E2E tests (13 files) = 1204 total tests
**Test Coverage:** 1014 unit tests (51 files) + 198 E2E tests (13 files) = 1212 total tests
All P0-P5 items are complete. The project is feature complete.
@@ -97,22 +97,22 @@ All P0-P5 items are complete. The project is feature complete.
| PeriodDateModal | 22 | Period input modal |
| Skeletons | 29 | Loading states with shimmer |
### E2E Tests (13 files, 190 tests)
### E2E Tests (13 files, 198 tests)
| File | Tests | Coverage |
|------|-------|----------|
| smoke.spec.ts | 3 | Basic app functionality |
| auth.spec.ts | 20 | Login, protected routes, OIDC flow, session persistence |
| dashboard.spec.ts | 40 | Dashboard display, overrides, accessibility |
| settings.spec.ts | 26 | Settings form, validation, persistence |
| settings.spec.ts | 27 | Settings form, validation, persistence, error recovery |
| garmin.spec.ts | 12 | Garmin connection, expiry warnings |
| period-logging.spec.ts | 19 | Period history, logging, modal flows |
| calendar.spec.ts | 30 | Calendar view, ICS feed, content validation |
| calendar.spec.ts | 34 | Calendar view, ICS feed, content validation, accessibility |
| decision-engine.spec.ts | 8 | Decision priority chain |
| cycle.spec.ts | 11 | Cycle tracking |
| history.spec.ts | 7 | History page |
| plan.spec.ts | 7 | Plan page |
| health.spec.ts | 3 | Health/observability |
| mobile.spec.ts | 4 | Mobile viewport behavior, responsive layout |
| mobile.spec.ts | 7 | Mobile viewport behavior, responsive layout, calendar mobile |
---
@@ -126,13 +126,18 @@ These are optional enhancements to improve E2E coverage. Not required for featur
| notifications.spec.ts | 3 | Notification preferences |
| dark-mode.spec.ts | 2 | System preference detection |
### Existing File Extensions
### Remaining Enhancements
| File | Additional Tests | Focus Area |
|------|------------------|------------|
| calendar.spec.ts | +4 | Responsive behavior, accessibility |
| settings.spec.ts | +1 | Error recovery on failed save |
| garmin.spec.ts | +4 | Token refresh, network error recovery |
### Completed Enhancements
| File | Tests Added | Focus Area |
|------|-------------|------------|
| calendar.spec.ts | +4 | Accessibility (ARIA, keyboard nav) |
| settings.spec.ts | +1 | Error recovery on failed save |
| mobile.spec.ts | +3 | Calendar responsive behavior |
---
## Notes
@@ -148,6 +153,7 @@ These are optional enhancements to improve E2E coverage. Not required for featur
## Revision History
- 2026-01-13: Added 8 E2E tests (calendar accessibility, settings error recovery, calendar mobile behavior)
- 2026-01-13: Added mobile.spec.ts with 4 E2E tests (mobile viewport behavior, responsive layout)
- 2026-01-13: Added 6 auth E2E tests (OIDC button display, loading states, session persistence across pages/refresh)
- 2026-01-13: Added 5 settings persistence E2E tests (notification time, timezone, multi-field persistence)