Alo/phaseflow
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add 5 new E2E tests for settings persistence
All checks were successful
Deploy / deploy (push) Successful in 2m28s
Details

Browse Source 
Tests added:
- notification time changes persist after page reload
- timezone changes persist after page reload
- multiple settings changes persist after page reload
- cycle length persistence verifies exact saved value
- settings form shows correct values after save without reload

Updated IMPLEMENTATION_PLAN.md with accurate E2E test counts (now 180 E2E tests).

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Petru
2026-01-13 18:31:39 +00:00
parent 79414b813a
commit c4d56f23e2
2 changed files with 244 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
IMPLEMENTATION_PLAN.md
View File

@@ -4,7 +4,7 @@ This file is maintained by Ralph. Run `./ralph-sandbox.sh plan 3` to generate ta
## Current Status: Feature Complete
**Test Coverage:** 1014 unit tests (51 files) + 175 E2E tests (12 files) = 1189 total tests
**Test Coverage:** 1014 unit tests (51 files) + 180 E2E tests (12 files) = 1194 total tests
All P0-P5 items are complete. The project is feature complete.
@@ -97,16 +97,16 @@ All P0-P5 items are complete. The project is feature complete.
| PeriodDateModal | 22 | Period input modal |
| Skeletons | 29 | Loading states with shimmer |
### E2E Tests (12 files, 175 tests)
### E2E Tests (12 files, 180 tests)
| File | Tests | Coverage |
|------|-------|----------|
| smoke.spec.ts | 3 | Basic app functionality |
| auth.spec.ts | 14 | Login, protected routes |
| dashboard.spec.ts | 24 | Dashboard display, overrides |
| settings.spec.ts | 15 | Settings form, validation |
| dashboard.spec.ts | 40 | Dashboard display, overrides, accessibility |
| settings.spec.ts | 26 | Settings form, validation, persistence |
| garmin.spec.ts | 12 | Garmin connection, expiry warnings |
| period-logging.spec.ts | 19 | Period history, logging, modal flows |
| calendar.spec.ts | 21 | Calendar view, ICS feed |
| calendar.spec.ts | 30 | Calendar view, ICS feed, content validation |
| decision-engine.spec.ts | 8 | Decision priority chain |
| cycle.spec.ts | 11 | Cycle tracking |
| history.spec.ts | 7 | History page |
@@ -130,8 +130,8 @@ These are optional enhancements to improve E2E coverage. Not required for featur
| File | Additional Tests | Focus Area |
|------|------------------|------------|
| auth.spec.ts | +6 | OIDC flow, session persistence |
| calendar.spec.ts | +13 | ICS content validation, responsive |
| settings.spec.ts | +6 | Persistence, timezone changes |
| calendar.spec.ts | +4 | Responsive behavior, accessibility |
| settings.spec.ts | +1 | Error recovery on failed save |
| garmin.spec.ts | +4 | Token refresh, network error recovery |
---
@@ -149,6 +149,7 @@ These are optional enhancements to improve E2E coverage. Not required for featur
## Revision History
- 2026-01-13: Added 5 settings persistence E2E tests (notification time, timezone, multi-field persistence)
- 2026-01-13: Added 5 period-logging E2E tests (modal flow, future date restriction, edit/delete flows)
- 2026-01-13: Added 5 Garmin E2E tests (expiry warnings, expired state, persistence, reconnection)
- 2026-01-13: Condensed plan after feature completion (reduced from 1514 to ~170 lines)