ppetru/opensprinkler-weather
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cleanup getWeatherData in DarkSky.ts

Browse Source
This commit is contained in:
Matthew Oslan
2019-05-20 16:41:12 -04:00
parent d58e48293d
commit 56bf8a5962
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
routes/weatherProviders/DarkSky.ts
View File

@@ -56,13 +56,17 @@ async function getDarkSkyWateringData( coordinates: GeoCoordinates ): Promise< W
async function getDarkSkyWeatherData( coordinates: GeoCoordinates ): Promise< WeatherData > { async function getDarkSkyWeatherData( coordinates: GeoCoordinates ): Promise< WeatherData > {
const DARKSKY_API_KEY = process.env.DARKSKY_API_KEY, const DARKSKY_API_KEY = process.env.DARKSKY_API_KEY,
forecastUrl = `https://api.darksky.net/forecast/${DARKSKY_API_KEY}/${coordinates[0]},${coordinates[1]}`; forecastUrl = `https://api.darksky.net/forecast/${DARKSKY_API_KEY}/${coordinates[0]},${coordinates[1]}?exclude=minutely,alerts,flags`;
let forecast; let forecast;
try { try {
forecast = await httpJSONRequest( forecastUrl ); forecast = await httpJSONRequest( forecastUrl );
} catch (err) { } catch (err) {
// Indicate watering data could not be retrieved if an API error occurs. // Indicate weather data could not be retrieved if an API error occurs.
return undefined;
}
if ( !forecast.currently || !forecast.daily || !forecast.daily.data ) {
return undefined; return undefined;
} }
@@ -76,16 +80,16 @@ async function getDarkSkyWeatherData( coordinates: GeoCoordinates ): Promise< We
region: "", region: "",
city: "", city: "",
minTemp: Math.floor( forecast.daily.data[ 0 ].temperatureLow ), minTemp: Math.floor( forecast.daily.data[ 0 ].temperatureMin ),
maxTemp: Math.floor( forecast.daily.data[ 0 ].temperatureHigh ), maxTemp: Math.floor( forecast.daily.data[ 0 ].temperatureMax ),
precip: forecast.daily.data[ 0 ].precipIntensity * 24, precip: forecast.daily.data[ 0 ].precipIntensity * 24,
forecast: [] forecast: [ ]
}; };
for ( let index = 0; index < forecast.daily.data.length; index++ ) { for ( let index = 0; index < forecast.daily.data.length; index++ ) {
weather.forecast.push( { weather.forecast.push( {
temp_min: Math.floor( forecast.daily.data[ index ].temperatureLow ), temp_min: Math.floor( forecast.daily.data[ index ].temperatureMin ),
temp_max: Math.floor( forecast.daily.data[ index ].temperatureHigh ), temp_max: Math.floor( forecast.daily.data[ index ].temperatureMax ),
date: forecast.daily.data[ index ].time, date: forecast.daily.data[ index ].time,
// TODO set this // TODO set this
icon: "", icon: "",