ppetru/opensprinkler-weather
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve handling of missing data in Dark Sky

Browse Source
This commit is contained in:
Matthew Oslan
2019-06-21 19:53:28 -04:00
parent 8d9fb96ea9
commit 930a0026de
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
routes/weatherProviders/DarkSky.ts
View File

@@ -56,9 +56,16 @@ export default class DarkSkyWeatherProvider extends WeatherProvider {
const totals = { temp: 0, humidity: 0, precip: 0 }; const totals = { temp: 0, humidity: 0, precip: 0 };
for ( const sample of samples ) { for ( const sample of samples ) {
/*
* If temperature or humidity is missing from a sample, the total will become NaN. This is intended since
* calculateWateringScale will treat NaN as a missing value and temperature/humidity can't be accurately
* calculated when data is missing from some samples (since they follow diurnal cycles and will be
* significantly skewed if data is missing for several consecutive hours).
*/
totals.temp += sample.temperature; totals.temp += sample.temperature;
totals.humidity += sample.humidity; totals.humidity += sample.humidity;
totals.precip += sample.precipIntensity // This field may be missing from the response if it is snowing.
totals.precip += sample.precipIntensity || 0;
} }
return { return {