ppetru/opensprinkler-weather
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #88 from OpenSprinkler/dst-fix

Browse Source 
Fix daylight saving time bug
This commit is contained in:
Samer Albahra
2020-03-09 13:59:51 -07:00
committed by GitHub
parent a351b8797d 601f6130d7
commit e354931438
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
routes/weatherProviders/DarkSky.ts
View File

@@ -41,7 +41,8 @@ export default class DarkSkyWeatherProvider extends WeatherProvider {
]; ];
// Fail if not enough data is available. // Fail if not enough data is available.
if ( samples.length !== 24 ) { // There will only be 23 samples on the day that daylight saving time begins.
if ( samples.length !== 24 && samples.length !== 23 ) {
throw new CodedError( ErrorCode.InsufficientWeatherData ); throw new CodedError( ErrorCode.InsufficientWeatherData );
} }
@@ -61,8 +62,8 @@ export default class DarkSkyWeatherProvider extends WeatherProvider {
return { return {
weatherProvider: "DarkSky", weatherProvider: "DarkSky",
temp: totals.temp / 24, temp: totals.temp / samples.length,
humidity: totals.humidity / 24 * 100, humidity: totals.humidity / samples.length * 100,
precip: totals.precip, precip: totals.precip,
raining: samples[ samples.length - 1 ].precipIntensity > 0 raining: samples[ samples.length - 1 ].precipIntensity > 0
}; };